Make the frontend a module for customview #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syucream
force-pushed
the
feature/frontend-core-module
branch
from
d161a0a to
72e1e9d
Compare
syucream
force-pushed
the
feature/frontend-core-module
branch
from
72e1e9d to
f747a93
Compare
|
Separated a large, independent improvement part as another PR: |
|
Now it works fine with my super simple sample project! https://github.com/syucream/pagoda-customview-example 
|
|
And also I've added a workflow to auto-publish the |
userlocalhost
approved these changes
Nov 21, 2024
|
Now my experimental module is available on https://github.com/users/syucream/packages/npm/pagoda-core/versions 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current custom view is being in chaos ...
frontend/src/customview/..., a non-scalable way ...So I wanna propose a smarter integration way between core (this repo) and custom views. Just providing this frontend implementations as a node module, then make developers to extend it theirselves. Thats like class-extension in some object-oriented languages,
class MyCustomView extends PagodaCore { ....Its an example customview project to extend that with a simple React components.
https://github.com/syucream/pagoda-customview-example